-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cypress test #148
base: develop
Are you sure you want to change the base?
Feature/cypress test #148
Conversation
@sudip-md thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sudip-md, Thanks for adding additional tests and raising a PR. I have updated the initialize script to fix tests failing in the GH action environment. However, I have added 2 notes on the PR. Could you please help with checking on those? Once it is resolved, we will be able to merge this.
Thank you.
it("Create Article Status", () => { | ||
cy.visit(`wp-admin/edit-tags.php?taxonomy=pi-article-status&post_type=print-issue`); | ||
cy.get('#tag-name').type('Active-01'); | ||
cy.get('#submit').click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add a verification step here to confirm that the article status was created successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamdharmesh probably best if you help get things updated for this PR and merge in
cy.get('[aria-label="“Active-01” (Edit)"]').click(); | ||
cy.get('#name').clear(); | ||
cy.get('#name').type('Active-02') | ||
cy.get('.button').click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, Add a verification step to confirm status edited successfully. Could you please help to add verification steps for all the tests?
###Local Test Result
Description of the Change
Added and update test cases
Closes #
How to test the Change
Changelog Entry
Checklist: